Ignore undefined as canonical url (#31882)

This commit is contained in:
David Roetzel 2024-09-12 13:14:42 +02:00 committed by GitHub
parent 3d46f47817
commit ab763c493f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions

View File

@ -225,7 +225,7 @@ class LinkDetailsExtractor
end
def valid_url_or_nil(str, same_origin_only: false)
return if str.blank? || str == 'null'
return if str.blank? || str == 'null' || str == 'undefined'
url = @original_url + Addressable::URI.parse(str)

View File

@ -33,6 +33,14 @@ RSpec.describe LinkDetailsExtractor do
expect(subject.canonical_url).to eq original_url
end
end
context 'when canonical URL is set to "undefined"' do
let(:url) { 'undefined' }
it 'ignores the canonical URLs' do
expect(subject.canonical_url).to eq original_url
end
end
end
context 'when only basic metadata is present' do